(REQ Plz) Simple Take Profit EA based on Bollinger Bands

[Guest sparky08]

Maybe some of the following functionality can be added if possible:

 

- IsBuyPinbar, IsSellPinbar functions - these pinbars needs to be sticking out from the BB

- IsEngulfed_Bar - tested for the many prior bars

- Test of Stoch <20

- Around the trigger candle (the bar before the entry bar) - is round number around, around the prior swing low and is the 200 & 365 ma's around the trigger candle (falls inside the candle or around 1-5 pips of the tigger candle)

- Firstly maybe we could put the above info on the dashboard - doesnt matter if its messy - lets test it first, then we can worry about the cosmetic changes later.

[Guest sparky08]

Please note that many of the above functions were written in many EA's - maybe we can use ideas from those ones, if the need be I can provide links to them, let me know.

[middx58]

Hi Guys,

 

Just to let you know that I have not forgotten about this. Just in the thick of it at work............

 

Appreciate the patience and good to see the continued interest in the thread.

 

Hello Kenny,

 

I wonder if you have the latest version ready for us to try out and test.

 

Many thanks and Best regards,

Edited November 21, 2010 by middx58

[kennyhubbard]

Hi guys,

 

Ok, I have to confess that I have been vegitating for the last 10 days since my course finished, so I have been neglecting the commitements that I have made here. I am slowly getting back into my coding frame of mind and I hope to release an update in the next week.

 

The first update will be some simple ones like the ability to change % lots to be closed at middle BB and I will also be removing some of the features that are proving to be problematic like the preventing of the EA running if there is already another chart of the same timeframe and instrument running. I have come to the conclusion that there is no problem running 2 of the same charts at the same time but with the code as it is causes endless problems if your platform gets closed in a non-standard way eg computer or platform crash.

 

Sparky, you have made several suggestions, some of which I will be taking into consideration. I already have much of the code for the various reversal patterns and will slowly start working them into the dashboard.

 

In the meantime Benny, perhaps you could bring me up to speed on what the latest is with your system and have there been any developments in what should appear in the dashboard.

[chrisbenjy]

Can anybody help me asap please. I have the EA open, but it says EA is already active on a pair and thus will be inactive on this pair. But it isn't, this is the only instance of the EA I'm running.

 

I have a live trade open so does any one know a solution please?

 

http://img217.imageshack.us/img217/5579/dumbasserror.jpg

 

Edit: Had to close the trade at a loss, because I'm not leaving a vulnerable order open without order management.

 

Can anyone pleas explain to me (i) why the EA seems to think I'm running multiple instances. (ii) how to solve it before I lose any more money.

Edited November 23, 2010 by chrisbenjy

[benny3]

Can anybody help me asap please. I have the EA open, but it says EA is already active on a pair and thus will be inactive on this pair. But it isn't, this is the only instance of the EA I'm running.

 

I have a live trade open so does any one know a solution please?

 

It's happened to me b4 what i did was

 

Right click the EA then remove it from the chart then add it again.

 

If that doesn't work then remove the EA from your chart again and close metatrader then reopen it again

 

hope that helps

[chrisbenjy]

Thanks for tying to help, but it didn't work.

[chrisbenjy]

Does anyone else have any suggestions because this is really pissing me off now. Just lost money on a trade that would currently be in profit and now I cannot open any more trades because the EA has decided it wants to be "inactive". X-(

[chrisbenjy]

Hello all, sorry for my frustration earlier.

 

I have solved the problem. In the include file I just changed

 

int result = MessageBoxA(0 ,"Warning!!! This EA is already running on the same pair and TF!!!"+"\n" + "EA will be inactive.",WindowExpertName(),MB_OK);
        Can_Run = false;

 

to

int result = MessageBoxA(0 ,"Ignoring Error",WindowExpertName(),MB_OK);
        Can_Run = true;

 

It will probably cause serious problems if I actually do end up putting the EA on the same pair and tf, but I just have to make sure I don't.

 

Unfortunately now that the problem is fixed, it is too late to re-enter the trade.

[kennyhubbard]

Hi Chris,

 

This will be fixed in the next update. Of course you have found a work around but or the rest of the guys, if you get this problem, close all the warning boxes and then hit F3. Delete all the Global Variables in the box that appears and re-launch the EA.

[kennyhubbard]

Minor update,

 

http://www.multiupload.com/H4IKT4G6RY

http://www.multiupload.com/H4IKT4G6RY

http://www.multiupload.com/H4IKT4G6RY

http://www.multiupload.com/H4IKT4G6RY

 

Download links for the Bol_TP EA plus the include file as well as the 2 scripts.

 

I have removed the instrument/timeframe protection, so hopefully this should cease causing issues. I have also fixed one or two minor bugs with the display.

 

I have now included the ability to change the lotsize that gets closed at the mid BB. This is controlled by external parameter "Close_Percent". The EA will automatically close the sleceted % or the broker minimum trade size whichever is greater.

 

There is still an issue where the EA will produce an error when the trade close at mid BB constitutes the whole trade(eg your original trade is the minimum broker trade size). When this trade is closed at mid BB, the EA will look for a ticket for the remainder of the trade which will not exist since the whole trade was closed. The error is only a nuisance error and does not affect the operation of the EA and I will eventually find a work around.

[smurf43]

Minor update,

 

http://www.multiupload.com/H4IKT4G6RY

http://www.multiupload.com/H4IKT4G6RY

http://www.multiupload.com/H4IKT4G6RY

http://www.multiupload.com/H4IKT4G6RY

......

 

Thank you Kenny. But all the download links you have provided are the same. Please revise. Thanks!

[kennyhubbard]

Smurf, well spotted.......sorry about that. Seems I can't even get the cut and paste right these days. Anyway, herewith the (hopefully) correct links.

 

http://www.multiupload.com/0S4YD0GX40

http://www.multiupload.com/BE5LM3P20P

http://www.multiupload.com/H4IKT4G6RY

http://www.multiupload.com/UHRQK9KEGY

[smurf43]

Smurf, well spotted.......sorry about that. Seems I can't even get the cut and paste right these days. Anyway, herewith the (hopefully) correct links......

 

Thank you Kenny. Well .... you have very very important and admirable skills (e.g. MQL4 programming) and personal qualities (e.g. unselfishly helping others). So please don't beat yourself up for making mistake in cut-n-paste. I am sure, it happend in a hurry to help us out!

 

Thank you very much, once again!

Edited November 25, 2010 by smurf43

[benny3]

Thank you Kenny for your great help.

 

Regards Benny3

[kennyhubbard]

http://www.multiupload.com/5XK5P945Y0

 

Just a small update for the dashboard. This only affect users that trade with brokers who have a suffix attached to their currency pairs. I discovered that the dashboard does not function when there is a suffix present.

 

Given the fact that no-one has mentioned this problem, I am not sure how big a problem it is for people but it is fixed now.

[smurf43]

http://www.multiupload.com/5XK5P945Y0

 

Just a small update for the dashboard. This only affect users that trade with brokers who have a suffix attached to their currency pairs. I discovered that the dashboard does not function when there is a suffix present.

 

Given the fact that no-one has mentioned this problem, I am not sure how big a problem it is for people but it is fixed now.

 

Thanks Kenny

 

When I tried to compile in Forex.com MT4 (pairs are with suffix FXF e.g. EURUSDFXF) , it gave following warnings.

 

Function "BullishEngulfingExists" is not referenced and will be removed from exp-file

Function "BullishHaramiExists" is not referenced and will be removed from exp-file

Function "DojiAtBottomExists" is not referenced and will be removed from exp-file

Function "DojiAtTopExists" is not referenced and will be removed from exp-file

Function "BearishHaramiExists" is not referenced and will be removed from exp-file

Function "LongUpCandleExists" is not referenced and will be removed from exp-file

Function "LongDownCandleExists" is not referenced and will be removed from exp-file

Function "BearishEngulfingExists" is not referenced and will be removed from exp-file

Function "SpinningTopExists" is not referenced and will be removed from exp-file

0 error(s), 9 warning(s)

 

I would appreciate it, if you could please fix these. Thank you!

[kennyhubbard]

Hi Smurf,

 

Those are warnings and do not need to be fixed. They are irrelevant to the operation of the dashboard.

 

I have included certain functions for future development and the compiler is simply telling you that it has detected that these functions are not being used, and because of this they are not included in the final compiled ex4 file.

[benny3]

Hi Kenny can you please add the option to take half at center BB or not.

 

And also the option to close at outer BB's or not

 

For example I enter a trade using the scripts, then the EA puts in the stoploss that's all i want to be able to do for now,no closing at center and no closing at outer just let it run.

 

Regards Benny3

[middx58]

Hi Kenny can you please add the option to take half at center BB or not.

 

And also the option to close at outer BB's or not

 

For example I enter a trade using the scripts, then the EA puts in the stoploss that's all i want to be able to do for now,no closing at center and no closing at outer just let it run.

 

Regards Benny3

 

Hi Kenny,

 

I wondered if you had chance to do any futher update on this please.

 

Many thanks!

[jonnnny23]

Hi everyone,

 

I have been trying to back test this ea and am having difficulties.

 

I have tried multiple back tests with different currencies and time frames and the EA never triggers a trade.

 

I am using all the default settings except

fixed lot size: 0.2

since my demo broker doesn't use mini lots.

 

Am I missing something in the ea setup???

 

Thanks,

[benny3]

Hi everyone,

 

I have been trying to back test this ea and am having difficulties.

 

I have tried multiple back tests with different currencies and time frames and the EA never triggers a trade.

 

I am using all the default settings except

fixed lot size: 0.2

since my demo broker doesn't use mini lots.

 

Am I missing something in the ea setup???

 

Thanks,

 

Friend, it doesn't open trades. It's a trade management Expert Adviser.

 

Example: You open 0.1 lots with the scripts then the EA places your stoploss and takes half (0.05) at center Bollinger Band, and then the rest at the outer Bollinger Band.

 

Hope this helps.

[kennyhubbard]

http://www.multiupload.com/DZ4A6FDOQH

http://www.multiupload.com/L5866WG45U

http://www.multiupload.com/CPD2L6SOUA

http://www.multiupload.com/FOLFVC91BS

http://www.multiupload.com/WIRUGAQCDY

 

Benny,

 

Here is the EA that you can use with the BB closing stripped out. I have renamed it Script_Controller_EA. I have created a "new" EA as the logistics of removing all the BB logic and still keeping the original EA funtioning would have been too complex.

 

There are 5 files.....

 

1.....The new Script_Controller_EA

2.....The Bol_TP_Include files, which uses common functions. Replace your orginal include file with this one, as there have been changes.

3.....Buy Scipt

4.....Sell Script

5.....Slightly modified original Bol_TP_v4_Enhanced EA. This has been slightly modified to be compatible with the changes to the include file.

 

I have not tested this extensively, so I expect some bugs. Please report them here as usual.

 

K.

[benny3]

Kenny thank you very much, I appreciate all the work you've put in despite your busy schedule.

 

Regards Benny3

Edited December 20, 2010 by benny3

[austine65]

Hi Kenny,

 

I wondered if you had chance to do any futher update on this please.

 

Many thanks!

 

Hello middx58.

 

I think quik_trailing MM will do the job for you. You can search in the forum for quik_trailing.

 

Hope it will meet your need.

 

Austin