Jump to content

BobR

Members
  • Posts

    124
  • Joined

  • Last visited

  • Days Won

    2

Posts posted by BobR

  1. I got a loss of 110 Pips just today 1st Feb opened at 8.45 GMT

     

    I have to comply with NFA regulations. A Breakout trade was already open and that prevented the Scalper from opening the trade you mention. Coincidentally, that was the one profitable Breakout trade I had.

     

    I am sorry you had a 110 pip loss. I can only tell you that I have seen the Scalper adjust the SL of its trades repeatedly such that all but two of them closed in profit in my testing.

  2. For strategy1 SL Is the highest ie 110 Pips

     

    I think that is just a safety net SL. The system modifies SL over the course of the trade.

     

    From your 2 wks of testing which is the best strategy

     

    The breakout strategy #2 has been the *worst* performer. All its trades save one have been losers because FXCombo did not adjust SL in a timely fashion for whatever reason. All other strategies have had good results. Scalping has lost money on only two trades. The Reversal strategy #3 and the EuroRange strategy #4 trades have all been winners. Except for setting ECN to False and NFA to True and using MoneyManagement to set lot sizes, I am using default settings. I am only running FXCombo on a demo system.

  3. Here is version 225.1g; try it.

     

    Here's the testing I did, FWIW.

     

    V224.1 can't decompile Joury V2 and neither can v225.1g.

     

    V224 can decompile Forex Combo 3.1, and so can v225 but with some differences.

     

    The handling of "not" logic is changed --

     

    v224: if (!IsTesting() && IsStopped()) return (0);

    if (!IsTesting() && !IsTradeAllowed()) {

     

    v225: if ((!IsTesting()) && IsStopped()) return (0);

    if ((!IsTesting()) && !IsTradeAllowed()) {

     

    I'm hoping this is fixing a problem, but I can't really tell without further research. The extra parentheses sure don't make the code easier to understand. Also, the second comparison on the second line seems inconsistent with the others.

     

    Gluttons for punishment will appreciate this more convoluted statement:

     

    V224: if (!(TimeHour(TimeCurrent()) != li_432 && TimeHour(TimeCurrent()) != li_436 && TimeHour(TimeCurrent()) != li_440 && TimeHour(TimeCurrent()) != li_444 && TimeHour(TimeCurrent()) != li_448 &&

    TimeHour(TimeCurrent()) != li_452 && TimeHour(TimeCurrent()) != li_456 && TimeHour(TimeCurrent()) != li_460 && TimeHour(TimeCurrent()) != li_464 && TimeHour(TimeCurrent()) != li_468 && TimeHour(TimeCurrent()) != li_472) ||

    !(TimeHour(TimeCurrent()) != li_476)) {

     

    V225: if ((!(TimeHour(TimeCurrent()) != li_432 && TimeHour(TimeCurrent()) != li_436 && TimeHour(TimeCurrent()) != li_440 && TimeHour(TimeCurrent()) != li_444 && TimeHour(TimeCurrent()) != li_448 &&

    TimeHour(TimeCurrent()) != li_452 && TimeHour(TimeCurrent()) != li_456 && TimeHour(TimeCurrent()) != li_460 && TimeHour(TimeCurrent()) != li_464 && TimeHour(TimeCurrent()) != li_468 && TimeHour(TimeCurrent()) != li_472)) ||

    !(TimeHour(TimeCurrent()) != li_476)) {

     

     

    Generated variable names were less informative in v225:

     

    V224: double l_bid_544 = 0;

    V225: double ld_544 = 0;

     

     

    V225 seems slower starting up than v224. As for a virus, neither Avast nor Malewarebytes detected anything unusual.

     

    So, I'll keep it in the arsenal. There might be something it can handle that v224 can't. Maybe all that extra grouping of the "not" logic is needed, but then I've always felt that using "not" logic is the hallmark of a poor programmer.

  4. the trades are reversed, but the sl tp levels are not

     

    OK, here ya go....

     

     http://www.multiupload.com/JICBN9FT90 

     

    I changed two fixed variables to be externals. They are TPfactor and SLfactor. Currently, they're set to 0.5 and 0.2 as in the original code. So to reverse them, set TPfactor to 0.2 and SLfactor to 0.5. Of course, you can also set them to whatever you want.

    I did it this way to retain the original intent of the code. The TP and SL are computed based on a High/Low range and not a fixed value.

  5. BobR, if you could fix it that would be tops.

     

    It's even worse than I first thought. I found the key in an XML file. SLAVE.DLL performs RSA decryption to unlock the EA.

    The DLL can be bypassed if you're willing to sacrifice the risk management function.

    Also, three include files are missing: TradingTimer.mqh, OrdersManagerPublic.mqh and CommonFunctions.mqh. Do you have these or can you round them up? The EA can't be compiled without them.

  6. The RoboMiner trades only the AUDNZD and EURCHF currency pairs, I think that the trade of these experts will be the same.

     

    You hit the nail on the head, Vladimir. I compared FX-Trust's code to a copy of Robo-Miner II v2.21. While there are some minor modifications, the two codes are almost identical.

  7. It is worrisome that you used zeroes in the OrderSelect function instead of SELECT_BY_POS and MODE_TRADES. As MODE_TRADES is the the default anyway, you could just as easily leave that out. I'd suggest changing the statement to if(OrderSelect(a, SELECT_BY_POS)).

     

    Please give more details about the problem(s) you're having? Any error messages logged under the experts tab and the journal tab will be helpful, too.

  8. I'm scared to open the regcode, are you sure that this regcode doesn't cause problems to the system registry?

     

    Here's what's in import_me.reg. As you can see, all it does is insert a license key. This is very common among commercial Windows products.

     

    Windows Registry Editor Version 5.00

     

    [HKEY_CURRENT_USER\Software\ForexBody]

    "ProductKey"="12345678901234567890123456789077"

  9. can anyone educate it?

     

    This EA uses the DLL to "phone home" to validate the license and to get buy/sell signals. The buy/sell signals are derived from the open and close of the last completed bar and a simple moving average. If someone can figure out the buy/sell calculation, it will be possible to bypass the DLL.

     

    Here's the decompiled code, FWIW....

     

     http://www.multiupload.com/Z2A46SMEEE 

  10. Maybe one of you programmers could educate this great EA.

     

    Here ya go, Prophetvs --

     

     http://www.multiupload.com/98JRX8OGPA 

     

    I also included an educated $Profit Manager.mq4

     

    You don't need MTFTP.DLL with these and because you included "SmartTrader 1.1.tpl" in your upload, there's no need to run "SmartTraderSetup v1.1.exe" either.

     

    Bon appetit!

  11. Zero divide doesn't affect how it trades

     

    I don't know about that. When I got a zero divide error, MT4 shut down the EA, so it wasn't trading at all. Actually, it looked like it wasn't even initialized as the comments never appeared on the chart.

     

    To circumvent the zero divide error, for each of the 17 pairs that the xtreme version uses, I opened a chart, cycled through all of the time frames, and then closed the chart. Haven't had a zero divide since. Maybe this will work for those who are also having a problem with this.

  12. Duplicate of PushButtonPips! Same person, same coding!

     

    I don't know how you came to that conclusion. While there are some similarities in their code, they use vastly different strategies. 1clickpips is evaluating differences in moving averages between pairs on the same broker's MT4 to determine when to initiate trades. PushButtonPips, OTOH, is attempting arbitrage trading of the same pair across two different broker's MT4 platforms.

×
×
  • Create New...