Dacky Posted March 5, 2011 Author Report Share Posted March 5, 2011 Richdad, thank for your explanation.. Jen, minlot that broker allowed migth be effected to this case...Note lot order it calculate from total order lot that cal from account and risk/ the number of order will be open...example 0.8/4= Cider, thank for your interresting this work... why good thing cannot be free.......? :))see my first post for source code Can someone edit the tread topic to note the first page are updated EA and Filter....please... Happy trading CiDER 1 Quote Link to comment Share on other sites More sharing options...
jennifer_tam41 Posted March 5, 2011 Report Share Posted March 5, 2011 Hi Dacky and Richdad711, + Thanks to Richdad711 for your clear explanations. + Dacky, You are good and generous. Right, good stuffs can also be shared if the person has good sharing spirit with public. By the way, Dacky, on your version V3.4, I saw there are many different Magic nos that made me confused. I do not know how to use all these magic no.s What I need is only 1 magic no. externally on Input parameter so that if I put your ea on Eurchf, I will use magic no. like 1111, and if I use your ea on another pair EURGBP, I will change magic no. to be 2222, and if using on USDCAD, I will change it to 3333, etc. I wonder why there are many different magic no.s as default settings. Please kindly explain me more clearly. Thanks a lot for your time. By the way, I do not see many people showing interests in this potentially profitable ea? I do not see many comments on backtesting, forward-testing results of good preset files for this ea on EURCHF, EURGBP, USDCAD, EURUSD, etc? Let's try to give our comments, suggestions or any good ideas to improve this ea even much more profitable. + In addition, what is the new change in your newer version V3.5 ? Have you backtested your ea on EURGBP, and EURUSD? I opine your ea works very well on these 2 pairs as well. Have a nice weekend to all ! Jennifer Quote Link to comment Share on other sites More sharing options...
CiDER Posted March 5, 2011 Report Share Posted March 5, 2011 Dacky the mq4 link doesn't work - The file link that you requested is not valid. I tested it for over a day now and the EA hasn't made any trades??? Quote Link to comment Share on other sites More sharing options...
jennifer_tam41 Posted March 5, 2011 Report Share Posted March 5, 2011 Hi Cider, I confirmed that all links worked without problem, including link of mq4 source code. You should try again. My friend confirmed that on backtest, the ea did place several trades (because default setting of max trades = 5). So, maybe, you need to do it again, too. Best regards, Jennifer CiDER 1 Quote Link to comment Share on other sites More sharing options...
CiDER Posted March 5, 2011 Report Share Posted March 5, 2011 The link works now. I'm still trying the EA and it's not doing anything; could it be a 5 digit broker bug? My settings file: NewsFilter=1 HighImpact=1 MinsAftHighImpact=120 MinsBefHighImpact=60 MediumImpact=0 MinsAftMediumImpact=60 MinsBefMediumImpact=30 LowImpact=0 MinsAftLowImpact=30 MinsBefLowImpact=15 IncludeSpeaks=1 DrawNewsLine=1 MoneyManagement=1 ECN=1 Risk=30 Lots=0.10000000 MaxLots=50.00000000 MaxOrder=5 hidesl=0 hidetp=0 Internal_TP=1 Internal_SL=1 TP=8.00000000 SL=18.00000000 LotPrecision=1 Slippage=2 MaxSpread=3.00000000 AutoGMT=1 ManualGMT=0 DSToffset=0 TimeH_Enter=22 TimeM_Enter=5 TimeH_Exit=1 TimeM_Exit=15 Time_Protection=1 Time_filter=1 Time_filter01=0.00040000 Time_filter02=0.00800000 Time_filter03=0.16000000 Magic1=3152644 Magic2=3152645 Magic3=3152646 Magic4=3152647 FractalRange=18 ATR_Level=12 FractalPrice=3 PF_Time1=60 PF1=3 PF_Time2=140 PF2=2 PF_Time3=170 PF3=1 PF_Time4=200 PF4=1 PF_Time5=240 PF5=4 IRSI=1 ICCI=1 MOMENTUM=1 IWPR=1 Quote Link to comment Share on other sites More sharing options...
richdad711 Posted March 6, 2011 Report Share Posted March 6, 2011 Hi Dacky and Richdad711, + Thanks to Richdad711 for your clear explanations. + Dacky, You are good and generous. Right, good stuffs can also be shared if the person has good sharing spirit with public. By the way, Dacky, on your version V3.4, I saw there are many different Magic nos that made me confused. I do not know how to use all these magic no.s What I need is only 1 magic no. externally on Input parameter so that if I put your ea on Eurchf, I will use magic no. like 1111, and if I use your ea on another pair EURGBP, I will change magic no. to be 2222, and if using on USDCAD, I will change it to 3333, etc. I wonder why there are many different magic no.s as default settings. Please kindly explain me more clearly. Thanks a lot for your time. By the way, I do not see many people showing interests in this potentially profitable ea? I do not see many comments on backtesting, forward-testing results of good preset files for this ea on EURCHF, EURGBP, USDCAD, EURUSD, etc? Let's try to give our comments, suggestions or any good ideas to improve this ea even much more profitable. + In addition, what is the new change in your newer version V3.5 ? Have you backtested your ea on EURGBP, and EURUSD? I opine your ea works very well on these 2 pairs as well. Have a nice weekend to all ! Jennifer Hi Jen, if you want to trade this EA on different pairs, you just need to change the magic numbers to something similar below From Magic1=3152644 Magic2=3152645 Magic3=3152646 Magic4=3152647 To Magic1=4152644 Magic2=4152645 Magic3=4152646 Magic4=4152647 same goes for your 3rd pair, you just need to change the 1st digit of the magic numbers Quote Link to comment Share on other sites More sharing options...
richdad711 Posted March 6, 2011 Report Share Posted March 6, 2011 The link works now. I'm still trying the EA and it's not doing anything; could it be a 5 digit broker bug? My settings file: NewsFilter=1 HighImpact=1 MinsAftHighImpact=120 MinsBefHighImpact=60 MediumImpact=0 MinsAftMediumImpact=60 MinsBefMediumImpact=30 LowImpact=0 MinsAftLowImpact=30 MinsBefLowImpact=15 IncludeSpeaks=1 DrawNewsLine=1 MoneyManagement=1 ECN=1 Risk=30 Lots=0.10000000 MaxLots=50.00000000 MaxOrder=5 hidesl=0 hidetp=0 Internal_TP=1 Internal_SL=1 TP=8.00000000 SL=18.00000000 LotPrecision=1 Slippage=2 MaxSpread=3.00000000 AutoGMT=1 ManualGMT=0 DSToffset=0 TimeH_Enter=22 TimeM_Enter=5 TimeH_Exit=1 TimeM_Exit=15 Time_Protection=1 Time_filter=1 Time_filter01=0.00040000 Time_filter02=0.00800000 Time_filter03=0.16000000 Magic1=3152644 Magic2=3152645 Magic3=3152646 Magic4=3152647 FractalRange=18 ATR_Level=12 FractalPrice=3 PF_Time1=60 PF1=3 PF_Time2=140 PF2=2 PF_Time3=170 PF3=1 PF_Time4=200 PF4=1 PF_Time5=240 PF5=4 IRSI=1 ICCI=1 MOMENTUM=1 IWPR=1 hi CiDER, same thing for me, it didnt open any trades since I put this EA to work with GoMarkets on my VPS and even put this on my home pc but no luck till now.... Quote Link to comment Share on other sites More sharing options...
Dacky Posted March 8, 2011 Author Report Share Posted March 8, 2011 Richdad and Cider, if you used 5 digits it might be the issued from spread, have to try to enable ECN?...it should working Dacky Quote Link to comment Share on other sites More sharing options...
jondgls Posted March 8, 2011 Report Share Posted March 8, 2011 Not ECN Compatibile Hello Dacky, I've been testing on ECN for the past few weeks (all versions) and I haven't had any trades either. No notes in the experts / journal tabs. I've taken a quick look at the code and found an error with the ECN point calculation, which results in a further errors wherever point is used. You have this in init(), which is the correct way to detect 5 digits and adjust point accordingly: if (Point == 0.00001) g_slippage_436 = 0.0001; else { if (Point == 0.001) g_slippage_436 = 0.01; else g_slippage_436 = Point; but then you do this which is causing errors: if (ECN == TRUE) { g_slippage_436 = 10.0 * g_slippage_436; TP = 10.0 * TP; SL = 10.0 * SL; Slippage = 10 * Slippage; MaxSpread = 10.0 * MaxSpread; } The first code block code changes g_slippage_436 to 0.0001 (because we are 5-Digit users). Then the second block multiplies 0.0001 * 10 so the result = 0.0010 (10 pips). The global point is now 0.0010 (10 pips) You then multiply the TP and SL by 10 so these variables are now TP 80 & SL 180. Later on you adjust these variables to doubles with this: g_price_628 = Bid - TP * g_slippage_436; where TP * g_slippage_436 has become 80 * 0.0010 and = 0.0800 (800 hundred pips) :( If you have this code block: if (Point == 0.00001) g_slippage_436 = 0.0001; else { if (Point == 0.001) g_slippage_436 = 0.01; else g_slippage_436 = Point; and you multiply the TP and SL throughout the code with the adjusted point, then you do not need to multiply the TP and the SL by 10 in the init(). I have only had a quick look but I can tell you this code will not function as-is on ECN brokers. If I get some time tomorrow I can take a longer look through what you've got. Regards, JonDgls Dacky 1 Quote Link to comment Share on other sites More sharing options...
Dacky Posted March 8, 2011 Author Report Share Posted March 8, 2011 JonDgls, Thank you very much for your advise....seems we have genius coder here...i not a programer... just look in to the code and modified...may be alot of thing to be correct....BTW...i not giving up yet. Happy trading Quote Link to comment Share on other sites More sharing options...
⭐ musketeer Posted March 8, 2011 Report Share Posted March 8, 2011 (edited) best way to get 4,5 digits broker: in the init myPoint = SetPoint(); double SetPoint() { double mPoint; if (Digits < 4) mPoint = 0.01; else mPoint = 0.0001; return(mPoint); } then just use myPoint when need it... Edited March 8, 2011 by musketeer CiDER and Dacky 2 Quote Link to comment Share on other sites More sharing options...
⭐ musketeer Posted March 8, 2011 Report Share Posted March 8, 2011 also do not forget to normalize... StopLossLevel = NormalizeDouble(StopLossLevel, Digits); Quote Link to comment Share on other sites More sharing options...
CiDER Posted March 8, 2011 Report Share Posted March 8, 2011 @Dacky Yes ECN is set to true. (I'm testing on an ECN broker) @musketeer Where would you add that function? I also had to change this line to get it to run: if (Symbol() != "EUR-CHF" || Period() != PERIOD_M5) To: if (Symbol() != "EURCHF" || Period() != PERIOD_M5) Quote Link to comment Share on other sites More sharing options...
⭐ musketeer Posted March 8, 2011 Report Share Posted March 8, 2011 @Dacky Yes ECN is set to true. (I'm testing on an ECN broker) @musketeer Where would you add that function? CiDER, that code is for any EA CiDER 1 Quote Link to comment Share on other sites More sharing options...
GreenTea Posted March 9, 2011 Report Share Posted March 9, 2011 I read the thread. I cannot get mine to trade on multiple pairs. rotating out of testing until someone posts about further development. thanks. Quote Link to comment Share on other sites More sharing options...
jondgls Posted March 10, 2011 Report Share Posted March 10, 2011 (edited) Hello Dacky, Here is an updated version for you. Please test on tickdata if you can. V34 change log: Fixed Point calculation Fixed Slippage, TP, SL & MaxSpread double conversions Fixed hideclosesell(); - Would have closed any EURCHF order with set TP reached (MagicNumber added). Fixed hideclosebuy(); - Would have closed any EURCHF order with set TP reached (MagicNumber added). Fixed TP variable - Only Internal_TP was working. Fixed a few Internal_TP - Missing. Fixed hidesl option - didn't work Fixed hidetp option - didn't work Fixed NewsFilter - Was always checking news regardless of "NewsFilter=FALSE". Fixed Lot size calculation Added true ECN compatibility - ECN servers require you to send the order without TP & SL first, then modify the order with these variables. Added Order Comment variable Simplified Magic Number variable - Enter one and 4 will be generated in init() Download: http://indo-investasi.com/showthread.php/11741-Modified-EA-BT-results-it-promising-from-1K-to-5M-within-2-Yrs?p=138986&viewfull=1#post138986 Regards, JonDgls Edited March 12, 2011 by jondgls forex4love, Trial1, favour and 12 others 15 Quote Link to comment Share on other sites More sharing options...
⭐ musketeer Posted March 10, 2011 Report Share Posted March 10, 2011 Good work Jondgls! :) Quote Link to comment Share on other sites More sharing options...
CiDER Posted March 10, 2011 Report Share Posted March 10, 2011 Thanks jondgls I'll test an ECN. Quote Link to comment Share on other sites More sharing options...
Dacky Posted March 11, 2011 Author Report Share Posted March 11, 2011 (edited) Express thank my good friend...Jondgls, and thank a lot for all friends here...to contribute all good thing and sharing.... :)) Edited March 11, 2011 by Dacky Quote Link to comment Share on other sites More sharing options...
Dacky Posted March 11, 2011 Author Report Share Posted March 11, 2011 I am just back to the tread...oh what on earth that all freind doing here....i can belive it the great work here will be develop very good and frofitable ea. Express Thank for my good friend...Jondgls.. Thank a lot all good freinds here to contributed to our tread.... CiDER...It can proved to you now...good thing canbe free...5555 Happy Trading and Happy waeaken with your family too. Dacky Quote Link to comment Share on other sites More sharing options...
CiDER Posted March 11, 2011 Report Share Posted March 11, 2011 It's now working on an ECN with jondgls modifications. Suffered big losses on all trades not one winner. 8115041 2011.03.11 00:08 sell 1.48 eurchf 1.28605 1.28782 1.28455 2011.03.11 04:10 1.28788 -9.39 0.00 0.00 -290.85 8115047 2011.03.11 00:08 sell 0.86 eurchf 1.28605 1.28777 1.28455 2011.03.11 04:10 1.28788 -5.46 0.00 0.00 -169.01 8115055 2011.03.11 00:08 sell 0.50 eurchf 1.28591 1.28801 1.28455 2011.03.11 04:18 1.28800 -3.17 0.00 0.00 -112.19 8115058 2011.03.11 00:08 sell 0.29 eurchf 1.28603 1.28799 1.28455 2011.03.11 04:18 1.28800 -1.84 0.00 0.00 -61.34 8115654 2011.03.11 00:43 sell 0.14 eurchf 1.28592 1.28782 1.28455 2011.03.11 04:10 1.28788 -0.89 0.00 0.00 -29.47 rmitsos 1 Quote Link to comment Share on other sites More sharing options...
rmitsos Posted March 11, 2011 Report Share Posted March 11, 2011 i had the same situation for nigh trades but not for day trades. I have disabled the time restriction (trades all day) and applied for EUR/USD - EURCHF. So far it has profits for both pairs. Symbol Lots Buy/sell Open price Close price Open time Close time Profit Swap Commission T/P S/L Pips Result Trade duration (hours) Magic number Order comment EURCHF 0.84 Sell 12.858 12.863 10/3/2011 21:18 11/3/2011 3:09 -45.15 -10.55 0 0 0 -5 Loss 5.86 3152645 DKT XC90 EURCHF 0.74 Sell 12.857 12.861 10/3/2011 21:18 11/3/2011 7:21 -31.76 -9.29 0 0 0 -4 Loss 10.06 3152645 DKT XC90 EURCHF 0.65 Sell 12.857 12.861 10/3/2011 21:18 11/3/2011 7:21 -27.9 -8.16 0 0 0 -4 Loss 10.06 3152645 DKT XC90 EURCHF 0.59 Sell 12.857 12.861 10/3/2011 21:18 11/3/2011 7:21 -25.33 -7.41 0 0 0 -4 Loss 10.06 3152645 DKT XC90 EURCHF 0.52 Sell 12.857 12.862 10/3/2011 21:18 11/3/2011 7:21 -27.89 -6.53 0 0 0 -5 Loss 10.06 3152645 DKT XC90 EURUSD 0.35 Sell 13.805 13.809 11/3/2011 0:25 11/3/2011 6:17 -14 0 0 0 0 -4 Loss 5.87 3152646 DKT XC90 EURUSD 0.34 Sell 13.805 13.808 11/3/2011 0:25 11/3/2011 6:17 -10.2 0 0 0 0 -3 Loss 5.88 3152646 DKT XC90 EURUSD 0.31 Sell 13.805 13.809 11/3/2011 0:25 11/3/2011 6:17 -12.4 0 0 0 0 -4 Loss 5.87 3152646 DKT XC90 EURUSD 0.19 Sell 13.826 13.825 11/3/2011 2:05 11/3/2011 3:17 1.9 0 0 0 0 1 Win 1.21 3152646 DKT XC90 EURUSD 0.17 Sell 13.826 13.823 11/3/2011 2:05 11/3/2011 3:17 5.1 0 0 0 0 3 Win 1.21 3152646 DKT XC90 EURCHF 0.38 Buy 12.863 12.871 11/3/2011 3:09 11/3/2011 4:02 32.65 0 0 0 0 8 Win 0.87 3152647 DKT XC90 EURUSD 0.3 Sell 13.827 13.824 11/3/2011 4:38 11/3/2011 5:50 9 0 0 0 0 3 Win 1.2 3152646 DKT XC90 EURUSD 0.29 Sell 13.827 13.819 11/3/2011 5:43 11/3/2011 6:13 23.2 0 0 0 0 8 Win 0.5 3152646 DKT XC90 EURCHF 0.22 Sell 12.878 12.868 11/3/2011 5:50 11/3/2011 6:23 23.59 0 0 0 0 10 Win 0.56 3152645 DKT XC90 EURCHF 0.19 Sell 12.878 12.869 11/3/2011 5:50 11/3/2011 6:23 18.34 0 0 0 0 9 Win 0.56 3152645 DKT XC90 EURUSD 0.01 Buy 1.382 13.823 11/3/2011 6:13 11/3/2011 8:05 0.3 0 0 0 0 3 Win 1.88 3152647 DKT XC90 EURUSD 0.01 Buy 13.818 13.821 11/3/2011 6:13 11/3/2011 8:05 0.3 0 0 0 0 3 Win 1.87 3152648 DKT XC90 EURUSD 0.02 Buy 1.381 13.818 11/3/2011 6:30 11/3/2011 6:36 1.6 0 0 0 0 8 Win 0.12 3152646 DKT XC90 EURUSD 0.03 Sell 13.831 13.829 11/3/2011 8:10 11/3/2011 9:11 0.6 0 0 0 0 2 Win 1.02 3152645 DKT XC90 EURCHF 0.03 Buy 1.287 12.878 11/3/2011 10:16 11/3/2011 10:57 2.57 0 0 0 0 8 Win 0.68 3152644 DKT XC90 Quote Link to comment Share on other sites More sharing options...
SpacyTrader Posted March 11, 2011 Report Share Posted March 11, 2011 (edited) http://www.4shared.com/photo/7DyBFwhG/StrategyTester_2.html http://www.4shared.com/document/iwquAK1-/StrategyTester.html -can`t belive something like this.....do you see what I see..? no loss...?:-O:-O:-O:-O don`t try with MM...account blower..:D Ce-ai folosit pt. rezultatele alea ? SL 0 ? Hmm- SL 18 TP 8. Unbelievable... I can see the problem- the last order was closed with a 41 pip loss- that would not have been possible if the 18 pip SL was working. The EA is not closing the orders at SL and is only closing in profit. Under these circumstances no wonder they're all wins. Edited March 11, 2011 by SpacyTrader Quote Link to comment Share on other sites More sharing options...
Guest dann0000 Posted March 11, 2011 Report Share Posted March 11, 2011 (edited) ..yeah..that`s true...internal SL don`t work...but why TP function on internal..?..starting BT with visible SL and TP...DAMN...LOOKS NICE... http://www.4shared.com/document/1IsJyvzo/StrategyTester_2.html Edited March 11, 2011 by dann0000 Quote Link to comment Share on other sites More sharing options...
Guest dann0000 Posted March 11, 2011 Report Share Posted March 11, 2011 ...internals SL and TP are really strange... http://www.4shared.com/document/63GBOuxc/StrategyTester_3.html Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.