Jump to content

(REQ Plz) Simple Take Profit EA based on Bollinger Bands


Recommended Posts

Hi kraven,

 

No problem, why don't you tell me your idea and I will give you an indication if it will disrupt the primary thread. Also, perhaps Benny can give his input into the idea........I personally think that this EA could perhaps benefit from having a trailing stop that kicks in when the half order is closed, but I don't trade this method, so I can't really say if this is better or not.

 

Benny, despite what you said about your preference to make the entries manually, we can look at automating the entries too.......

Link to comment
Share on other sites

  • Replies 274
  • Created
  • Last Reply

Top Posters In This Topic

ok mate, thanks.

 

first if you have the time check out the video and indicator here:

http://indo-investasi.com/showthread.php/8081-Share-with-friends-Bollinger-Band-and-Divergence-Trading

 

i posted my idea of how to trade it on that thread too.

Anyway i've done some testing using the divergence indicator in the thread above, with decent success. however instead of using a 'no stoploss policy' (as instructed by originator) i woulds take the high/low of either the divergence candle or the set-up candle (next one) whichever was greater.

I would like the EA to be as it is now (really a trade management system) with buy/sell being manual. To be able to choose high/low of the divergence or set-up candle (think this is already possible) plus a given number of pips. As talked about previously for the 'take-profit' to move with bolinger band as candles progress, so does BB, so does TP. i only plan on using 1 lot so no need for half closures etc. As i said i don't think it's too far from current, apart from adding pips, moving TP with BB and a simple 1 stop SL and TP. Thanks Kenny.

Link to comment
Share on other sites

realy Kenny if i could just enter the stoploss price that would be fine, then i could just add the extra pips too. it's the moving TP that'll be the hard part i think...hope a pic may make it clearer

 

%5Bimg%5Dhttp%3A//i988.photobucket.com/albums/af5/kraven69/v1-2.gif[/img]

 

As i said if i could just enter the SL price that would be great..it's the moving TP, as it moves with Bol Bands that i'm after. Thanks

Edited by kraven
Link to comment
Share on other sites

Hi Benny,

 

Just a quick question? Is the price action of the current bar below(or above) that of the stoploss level of the previous trade?

 

I'm prity sure it was above heres a pic. 1st trade

 

http://i38.tinypic.com/2vtacza.jpg

 

my 2nd trade taken earlier same day

 

http://i38.tinypic.com/14wwar.jpg

Link to comment
Share on other sites

Hi Benny,

 

Just a brief update, I haven't forgotten about this project, unfortunately my day job gets in the way from time to time.

 

I have had to take the project back to the drawing board since I have identified the problem causing the continuous partial closing of orders. Anyway, thanks for the patience, I should have it ready in a couple of days.

Link to comment
Share on other sites

Hi Benny,

 

Just a brief update, I haven't forgotten about this project, unfortunately my day job gets in the way from time to time.

 

I have had to take the project back to the drawing board since I have identified the problem causing the continuous partial closing of orders. Anyway, thanks for the patience, I should have it ready in a couple of days.

 

No worries Kenny Take As much time as needed.

Good things come to those who wait.

Link to comment
Share on other sites

http://www.multiupload.com/B285KNL5AX

 

Hi guys,

 

Here is the latest version. Just some comments.......

 

Benny, I am not at all sure I have solved the Stoploss bug since I have been unable to reproduce the error. There is no MagicNumber in use with this EA, so it will automatically take control of any and all trades on your platform.

 

Currently it adds Stoplosses on my testing platform(FXOpen) with no problems.

 

It modifies the TP as the BB changes on each bar. By default, this is using Close price of the current bar as the applied price. Change the Shift to 1 if you want to use the close of the previous bar. You can also change the applied price of the BB by changing the 'Applied_Price' external parameter. Use the following :-

 

PRICE_CLOSE 0 Close price.

PRICE_OPEN 1 Open price.

PRICE_HIGH 2 High price.

PRICE_LOW 3 Low price.

PRICE_MEDIAN 4 Median price, (high+low)/2.

PRICE_TYPICAL 5 Typical price, (high+low+close)/3.

PRICE_WEIGHTED 6 Weighted close price, (high+low+close+close)/4.

 

You can use the defined constants in the first column or the number in the second column. The third column is a basic description.

 

There will still be some bugs, I am sure. One issue that I am still concerned about is if there is a modification error when the partial order closes, it may lose the Original Entry Price as a stoploss and will use the very first stoploss instead. Hopefully I will find a way around this in the next version.

 

I have incorporated some extra error commenting, so when you have a bug, please let me have the Experts comments and the journal comments.

Edited by kennyhubbard
Link to comment
Share on other sites

Hi kraven,

 

Here is the link to your request.......no partial close, moving TP same as previous post.

 

http://www.multiupload.com/TCRTX0QR64

 

You can select the bars to use for the SL by changing the SL_Bars external parameter. You would probably use 3 because the current bar is the first bar, so I assume you would want the high/low for the preceeding 2 bars.

Link to comment
Share on other sites

http://www.multiupload.com/B285KNL5AX

 

Hi guys,

 

Here is the latest version. Just some comments.......

 

Benny, I am not at all sure I have solved the Stoploss bug since I have been unable to reproduce the error. There is no MagicNumber in use with this EA, so it will automatically take control of any and all trades on your platform.

 

Currently it adds Stoplosses on my testing platform(FXOpen) with no problems.

 

It modifies the TP as the BB changes on each bar. By default, this is using Close price of the current bar as the applied price. Change the Shift to 1 if you want to use the close of the previous bar. You can also change the applied price of the BB by changing the 'Applied_Price' external parameter. Use the following :-

 

PRICE_CLOSE 0 Close price.

PRICE_OPEN 1 Open price.

PRICE_HIGH 2 High price.

PRICE_LOW 3 Low price.

PRICE_MEDIAN 4 Median price, (high+low)/2.

PRICE_TYPICAL 5 Typical price, (high+low+close)/3.

PRICE_WEIGHTED 6 Weighted close price, (high+low+close+close)/4.

 

You can use the defined constants in the first column or the number in the second column. The third column is a basic description.

 

There will still be some bugs, I am sure. One issue that I am still concerned about is if there is a modification error when the partial order closes, it may lose the Original Entry Price as a stoploss and will use the very first stoploss instead. Hopefully I will find a way around this in the next version.

 

I have incorporated some extra error commenting, so when you have a bug, please let me have the Experts comments and the journal comments.

 

1

Hi Kenny the expert is putting in the stop alright, because i've finally figured it out that the bar that is the highes/lowest has to be above/below center bb. that could've been the reason why it was playing up.

 

2

Now soon as i got home i decided to try the expert and opened some trades, 1st making sure that the lowest/highes bar that my stop was going to be above/below 20 or so pips was good. 2nd making sure that price was above/below center bb. 3rd Then i executed my trades.

 

Now this is where the problem happens. I opened the 1st trade on USD/CHF here's a pic.

everything seems ok ..trade opened stop placed. great ...

http://i38.tinypic.com/2hdvd3b.jpg

 

then i open a new chart... on the GBP/USD

everything looks great the stop was placed 20 pips above highest candle...

that's when it just started closing orders one after the other

http://i36.tinypic.com/30iu811.jpg

Edited by benny3
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.




×
×
  • Create New...