kennyhubbard Posted August 22, 2010 Report Share Posted August 22, 2010 Hi kraven, No problem, why don't you tell me your idea and I will give you an indication if it will disrupt the primary thread. Also, perhaps Benny can give his input into the idea........I personally think that this EA could perhaps benefit from having a trailing stop that kicks in when the half order is closed, but I don't trade this method, so I can't really say if this is better or not. Benny, despite what you said about your preference to make the entries manually, we can look at automating the entries too....... Quote Link to comment Share on other sites More sharing options...
kraven Posted August 22, 2010 Report Share Posted August 22, 2010 ok mate, thanks. first if you have the time check out the video and indicator here: http://indo-investasi.com/showthread.php/8081-Share-with-friends-Bollinger-Band-and-Divergence-Trading i posted my idea of how to trade it on that thread too. Anyway i've done some testing using the divergence indicator in the thread above, with decent success. however instead of using a 'no stoploss policy' (as instructed by originator) i woulds take the high/low of either the divergence candle or the set-up candle (next one) whichever was greater. I would like the EA to be as it is now (really a trade management system) with buy/sell being manual. To be able to choose high/low of the divergence or set-up candle (think this is already possible) plus a given number of pips. As talked about previously for the 'take-profit' to move with bolinger band as candles progress, so does BB, so does TP. i only plan on using 1 lot so no need for half closures etc. As i said i don't think it's too far from current, apart from adding pips, moving TP with BB and a simple 1 stop SL and TP. Thanks Kenny. Quote Link to comment Share on other sites More sharing options...
kennyhubbard Posted August 22, 2010 Report Share Posted August 22, 2010 Hi kraven, Without going into the thread detail, can you tell me if it is as simple as taking the highest of the preceeding 2 bars rather than just the high or low of the 1 preceeding bar? Quote Link to comment Share on other sites More sharing options...
kraven Posted August 22, 2010 Report Share Posted August 22, 2010 (edited) realy Kenny if i could just enter the stoploss price that would be fine, then i could just add the extra pips too. it's the moving TP that'll be the hard part i think...hope a pic may make it clearer %5Bimg%5Dhttp%3A//i988.photobucket.com/albums/af5/kraven69/v1-2.gif[/img] As i said if i could just enter the SL price that would be great..it's the moving TP, as it moves with Bol Bands that i'm after. Thanks Edited August 22, 2010 by kraven Quote Link to comment Share on other sites More sharing options...
benny3 Posted August 23, 2010 Author Report Share Posted August 23, 2010 Hi Kenny i opened another trade this morning, with a different magic number but the EA wont even place a stop at all. Quote Link to comment Share on other sites More sharing options...
kennyhubbard Posted August 23, 2010 Report Share Posted August 23, 2010 Hi Benny, Just a quick question? Is the price action of the current bar below(or above) that of the stoploss level of the previous trade? Quote Link to comment Share on other sites More sharing options...
benny3 Posted August 23, 2010 Author Report Share Posted August 23, 2010 Hi Benny, Just a quick question? Is the price action of the current bar below(or above) that of the stoploss level of the previous trade? I'm prity sure it was above heres a pic. 1st trade http://i38.tinypic.com/2vtacza.jpg my 2nd trade taken earlier same day http://i38.tinypic.com/14wwar.jpg Quote Link to comment Share on other sites More sharing options...
benny3 Posted August 23, 2010 Author Report Share Posted August 23, 2010 it didn't even place a stoploss. Quote Link to comment Share on other sites More sharing options...
kennyhubbard Posted August 23, 2010 Report Share Posted August 23, 2010 Ok, thanks. I'm working on a version that I hope will be far more robust in error handling. Hopefully it will sort out the SL issue too. domonkos and benny3 2 Quote Link to comment Share on other sites More sharing options...
benny3 Posted August 23, 2010 Author Report Share Posted August 23, 2010 Ok, thanks. I'm working on a version that I hope will be far more robust in error handling. Hopefully it will sort out the SL issue too. Cheers, looking forward to testing it. Quote Link to comment Share on other sites More sharing options...
kennyhubbard Posted August 26, 2010 Report Share Posted August 26, 2010 Hi Benny, Just a brief update, I haven't forgotten about this project, unfortunately my day job gets in the way from time to time. I have had to take the project back to the drawing board since I have identified the problem causing the continuous partial closing of orders. Anyway, thanks for the patience, I should have it ready in a couple of days. domonkos and benny3 2 Quote Link to comment Share on other sites More sharing options...
kraven Posted August 26, 2010 Report Share Posted August 26, 2010 kenny will this move TP with the bolinger bands. thanks kenny Quote Link to comment Share on other sites More sharing options...
benny3 Posted August 26, 2010 Author Report Share Posted August 26, 2010 Hi Benny, Just a brief update, I haven't forgotten about this project, unfortunately my day job gets in the way from time to time. I have had to take the project back to the drawing board since I have identified the problem causing the continuous partial closing of orders. Anyway, thanks for the patience, I should have it ready in a couple of days. No worries Kenny Take As much time as needed. Good things come to those who wait. Quote Link to comment Share on other sites More sharing options...
kennyhubbard Posted August 27, 2010 Report Share Posted August 27, 2010 (edited) http://www.multiupload.com/B285KNL5AX Hi guys, Here is the latest version. Just some comments....... Benny, I am not at all sure I have solved the Stoploss bug since I have been unable to reproduce the error. There is no MagicNumber in use with this EA, so it will automatically take control of any and all trades on your platform. Currently it adds Stoplosses on my testing platform(FXOpen) with no problems. It modifies the TP as the BB changes on each bar. By default, this is using Close price of the current bar as the applied price. Change the Shift to 1 if you want to use the close of the previous bar. You can also change the applied price of the BB by changing the 'Applied_Price' external parameter. Use the following :- PRICE_CLOSE 0 Close price. PRICE_OPEN 1 Open price. PRICE_HIGH 2 High price. PRICE_LOW 3 Low price. PRICE_MEDIAN 4 Median price, (high+low)/2. PRICE_TYPICAL 5 Typical price, (high+low+close)/3. PRICE_WEIGHTED 6 Weighted close price, (high+low+close+close)/4. You can use the defined constants in the first column or the number in the second column. The third column is a basic description. There will still be some bugs, I am sure. One issue that I am still concerned about is if there is a modification error when the partial order closes, it may lose the Original Entry Price as a stoploss and will use the very first stoploss instead. Hopefully I will find a way around this in the next version. I have incorporated some extra error commenting, so when you have a bug, please let me have the Experts comments and the journal comments. Edited August 27, 2010 by kennyhubbard smurf43, benny3, fxshare and 1 other 4 Quote Link to comment Share on other sites More sharing options...
benny3 Posted August 27, 2010 Author Report Share Posted August 27, 2010 Kenny, YOU ARE THE MAN. Much appreciated. i wish there was some way i could help you. Im currently at work, so ill have to test this EA when i get home. cant wait hehe Quote Link to comment Share on other sites More sharing options...
kennyhubbard Posted August 27, 2010 Report Share Posted August 27, 2010 Hi kraven, Here is the link to your request.......no partial close, moving TP same as previous post. http://www.multiupload.com/TCRTX0QR64 You can select the bars to use for the SL by changing the SL_Bars external parameter. You would probably use 3 because the current bar is the first bar, so I assume you would want the high/low for the preceeding 2 bars. smurf43, domonkos, Mee and 1 other 4 Quote Link to comment Share on other sites More sharing options...
kraven Posted August 27, 2010 Report Share Posted August 27, 2010 thanks mate, i'll give it ago as soon as the oppertunity arises. thanks again Quote Link to comment Share on other sites More sharing options...
megainvest Posted August 27, 2010 Report Share Posted August 27, 2010 Hi Let me please know how this EA works in Live/Demo account. Thanks, megainvest Quote Link to comment Share on other sites More sharing options...
benny3 Posted August 27, 2010 Author Report Share Posted August 27, 2010 (edited) http://www.multiupload.com/B285KNL5AX Hi guys, Here is the latest version. Just some comments....... Benny, I am not at all sure I have solved the Stoploss bug since I have been unable to reproduce the error. There is no MagicNumber in use with this EA, so it will automatically take control of any and all trades on your platform. Currently it adds Stoplosses on my testing platform(FXOpen) with no problems. It modifies the TP as the BB changes on each bar. By default, this is using Close price of the current bar as the applied price. Change the Shift to 1 if you want to use the close of the previous bar. You can also change the applied price of the BB by changing the 'Applied_Price' external parameter. Use the following :- PRICE_CLOSE 0 Close price. PRICE_OPEN 1 Open price. PRICE_HIGH 2 High price. PRICE_LOW 3 Low price. PRICE_MEDIAN 4 Median price, (high+low)/2. PRICE_TYPICAL 5 Typical price, (high+low+close)/3. PRICE_WEIGHTED 6 Weighted close price, (high+low+close+close)/4. You can use the defined constants in the first column or the number in the second column. The third column is a basic description. There will still be some bugs, I am sure. One issue that I am still concerned about is if there is a modification error when the partial order closes, it may lose the Original Entry Price as a stoploss and will use the very first stoploss instead. Hopefully I will find a way around this in the next version. I have incorporated some extra error commenting, so when you have a bug, please let me have the Experts comments and the journal comments. 1 Hi Kenny the expert is putting in the stop alright, because i've finally figured it out that the bar that is the highes/lowest has to be above/below center bb. that could've been the reason why it was playing up. 2 Now soon as i got home i decided to try the expert and opened some trades, 1st making sure that the lowest/highes bar that my stop was going to be above/below 20 or so pips was good. 2nd making sure that price was above/below center bb. 3rd Then i executed my trades. Now this is where the problem happens. I opened the 1st trade on USD/CHF here's a pic. everything seems ok ..trade opened stop placed. great ... http://i38.tinypic.com/2hdvd3b.jpg then i open a new chart... on the GBP/USD everything looks great the stop was placed 20 pips above highest candle... that's when it just started closing orders one after the other http://i36.tinypic.com/30iu811.jpg Edited August 27, 2010 by benny3 Quote Link to comment Share on other sites More sharing options...
benny3 Posted August 27, 2010 Author Report Share Posted August 27, 2010 (edited) so kenny it seems that the stoploss is fixed now it's just the order closing.... just to close half at center and other half at highes/lowest BB. Here's the Journal http://i38.tinypic.com/nle5tv.jpg http://i38.tinypic.com/2vl5qqh.jpg http://i35.tinypic.com/11wdbx1.jpg Edited August 27, 2010 by benny3 kennyhubbard 1 Quote Link to comment Share on other sites More sharing options...
kennyhubbard Posted August 27, 2010 Report Share Posted August 27, 2010 Hi Benny, AAh, ok, I think I know what the problem is. I haven't made provision for use on multiple instruments. I will work on the multi version tonight, so just test it on the one currency pair for now. benny3 and domonkos 2 Quote Link to comment Share on other sites More sharing options...
kennyhubbard Posted August 27, 2010 Report Share Posted August 27, 2010 http://www.multiupload.com/XODK88ZDIF Ok guys, here is the next edition, this time being able to handle multi-currencies. That one was bit of a curved ball but I think I ironed out some of the problems. Benny, good reporting, that is exactly the kind of info I need in order to track down problems. benny3 and domonkos 2 Quote Link to comment Share on other sites More sharing options...
kennyhubbard Posted August 27, 2010 Report Share Posted August 27, 2010 Hi kraven, Herewith your updated EA to allow for multi-currencies. I'm sorry but I didn't have time to test it, so please just report any bugs here. http://www.multiupload.com/IW1K8GBV6L Enjoy! smurf43, kraven and domonkos 3 Quote Link to comment Share on other sites More sharing options...
kraven Posted August 27, 2010 Report Share Posted August 27, 2010 thanks kenny i'll test next week Quote Link to comment Share on other sites More sharing options...
wonder833 Posted August 28, 2010 Report Share Posted August 28, 2010 This does not work on backtest? i Have tried backtest, but nothing happen? Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.